chore(x-goog-spanner-request-id): set span attribute x_goog_spanner_request_id #3905
+40
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
odeke-em
force-pushed
the
x-goog-spanner-request-id-set-span-attribute
branch
from
76de4a6 to
9effc60
Compare
product-auto-label
bot
added
size: s
odeke-em
force-pushed
the
x-goog-spanner-request-id-set-span-attribute
branch
3 times, most recently
from
3ec60f7 to
93b9ef8
Compare
olavloite
added
the
kokoro:force-run
surbhigarg92
previously approved these changes
Jun 6, 2025
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
x-goog-spanner-request-id-set-span-attribute
branch
from
93b9ef8 to
cb62c7d
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
x-goog-spanner-request-id-set-span-attribute
branch
from
02525ea to
b237b96
Compare
|
@sakthivelmanii @surbhigarg92 @olavloite @rahul2393 kindly help me run the bots please. Also this PR can't run locally due to the mismatch in Java versions hence the only option is having it run on these bots. |
odeke-em
force-pushed
the
x-goog-spanner-request-id-set-span-attribute
branch
from
b237b96 to
593fae9
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
…equest_id This sets the span attribute x_goog_spanner_request_id so as to enable correlation with distributed tracing with OpenTelemetry. Updates googleapis#3537
odeke-em
force-pushed
the
x-goog-spanner-request-id-set-span-attribute
branch
from
593fae9 to
625c7dd
Compare
|
@sakthivelmanii @rahul2393 kindly help run the bots. |
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
| @@ -174,6 +175,10 @@ private void processHeader( | |||
| } | |||
| if (span != null) { | |||
| span.setAttribute("gfe_latency", String.valueOf(gfeLatency)); | |||
| String reqId = XGoogSpannerRequestId.getRequestIdFromMetadata(metadata); | |||
There was a problem hiding this comment.
We encountered an oddity that the Java Spanner client tests for OpenTelemetry only work for certain versions of Java as @olavloite mentioned in our group, so even testing anything requires y'all to help me run the bots /cc @tharoldD to help out with the updates.
product-auto-label
bot
added
size: m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the span attribute x_goog_spanner_request_id so as to enable correlation with distributed tracing with OpenTelemetry.
Updates #3537